Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add governance role to kinto admin #349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add governance role to kinto admin #349

wants to merge 3 commits into from

Conversation

VSBDev
Copy link
Contributor

@VSBDev VSBDev commented Mar 4, 2025

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Deployment
  • Forge Script
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

unchecked-transfer

Impact: High
Confidence: Medium

kinto-core/src/access/workflows/AaveWithdrawWorkflow.sol

Lines 50 to 64 in 18aa92b

function withdraw(address asset, uint256 amount) public returns (uint256) {
address pool = poolAddressProvider.getPool();
// If amount is max uint256, withdraw all available
if (amount == type(uint256).max) {
amount = IERC20(IAavePool(pool).getReserveData(asset).aTokenAddress).balanceOf(address(this));
}
// Withdraw from Aave
IAavePool(pool).withdraw(asset, amount, address(this));
// Send the fee to the Safe
uint256 fee = amount * FEE / 1e18;
IERC20(asset).transfer(safe, fee);
return amount - fee;
}

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (9f53019) to head (e8394aa).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files          42       42           
  Lines        2656     2656           
=======================================
  Hits         2367     2367           
  Misses        289      289

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Mar 4, 2025 •
edited
Loading

feat: add governance role to kinto admin

Generated at commit: e8394aacb5d79747e39b711c1fe213c0ca92bcc2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 4
2
0
12
39
57
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@VSBDev VSBDev requested a review from rrecuero March 4, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrecuero rrecuero rrecuero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VSBDev @rrecuero